The wriring looks ok (if yellow is really PWM on yours, as e.g. Noctua uses blue)
Does fan stop if you connect for a short test the fan’s PWM cable to ground?